Skip to content

Cover continuation and listener behaviour when registering no-op manager during tests#11762

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
mcculls/context-coverage
Jun 29, 2026
Merged

Cover continuation and listener behaviour when registering no-op manager during tests#11762
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
mcculls/context-coverage

Conversation

@mcculls

@mcculls mcculls commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Motivation

Get ./gradlew :components:context:check to pass locally

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

mcculls added 2 commits June 29, 2026 11:00
@mcculls
Cover continuation and listener behaviour when registering no-op mana…
b4c11ee 
…ger during tests.
@mcculls
Relax default 90% branch coverage rule to 80% for ContextContinuation…
20128f1 
…Impl

(couple of branches involve a nanosecond CAS race that can't be reliably reproduced)
@mcculls mcculls requested a review from a team as a code owner June 29, 2026 10:01
@mcculls mcculls added the comp: testing Testing label Jun 29, 2026
@mcculls mcculls requested review from sarahchen6 and removed request for a team June 29, 2026 10:01
@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring labels Jun 29, 2026
@mcculls mcculls requested a review from PerfectSlayer June 29, 2026 10:02
@dd-octo-sts

dd-octo-sts Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.82 s 14.72 s [-0.1%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 13.70 s 13.75 s [-1.3%; +0.6%] (no difference)
startup:petclinic:appsec:Agent 16.93 s 16.63 s [+0.9%; +2.8%] (maybe worse)
startup:petclinic:iast:Agent 16.79 s 16.94 s [-1.7%; -0.0%] (maybe better)
startup:petclinic:profiling:Agent 16.81 s 16.95 s [-1.8%; +0.2%] (no difference)
startup:petclinic:sca:Agent 16.38 s 16.75 s [-6.7%; +2.3%] (no difference)
startup:petclinic:tracing:Agent 16.03 s 16.17 s [-1.9%; +0.1%] (no difference)

Commit: 1c948872 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

PerfectSlayer
PerfectSlayer approved these changes Jun 29, 2026
View reviewed changes

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for the test changes but I would rather have @bric3 to review impact of afterEvaluate use 🙏

Comment thread components/context/build.gradle.kts Outdated
extra["excludedClassesBranchCoverage"] =
listOf("datadog.context.ThreadLocalContextManager.ContextContinuationImpl")

afterEvaluate {

@PerfectSlayer PerfectSlayer Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting review from @bric3 about afterEvaluate usage

@bric3 bric3 Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive afterEvaluate should not be needed, because the jacoco task is already using the lazy API. I.e. you can configure the task the same way just without afterEvaluate.

As a rule of thumb, afterEvaluate is mostly appropriate for validating finalized configuration, not for modifying task configuration.

@mcculls mcculls Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1c94887

@mcculls mcculls requested a review from bric3 June 29, 2026 12:50
@mcculls mcculls enabled auto-merge June 29, 2026 14:48
@mcculls mcculls added this pull request to the merge queue Jun 29, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-29 14:54:36 UTC ℹ️ Start processing command /merge

2026-06-29 14:54:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-06-29 16:03:08 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 75f8482 into master Jun 29, 2026
778 of 780 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/context-coverage branch June 29, 2026 16:03
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes
@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes
@sarahchen6 sarahchen6 Awaiting requested review from sarahchen6 sarahchen6 is a code owner automatically assigned from DataDog/apm-lang-platform-java

Assignees

No one assigned

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @bric3 @PerfectSlayer